Skip to content

Commit afc20cc

Browse files
committed
fix: #29 Refactor design
1 parent d404655 commit afc20cc

File tree

3 files changed

+14
-27
lines changed

3 files changed

+14
-27
lines changed

src/app/modules/shared/components/details-fields/details-fields.component.html

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
/>
3838
</div>
3939

40-
<div class="input-group input-group-sm mb-3">
40+
<div class="input-group input-group-sm">
4141
<div class="input-group-prepend">
4242
<span class="input-group-text span-width" id="inputGroup-sizing-sm">Technology</span>
4343
</div>
@@ -50,11 +50,10 @@
5050
/>
5151
</div>
5252

53-
<app-search-project (changeFilterProject)="filterTechnology = $event"></app-search-project>
5453
<div *ngIf="isLoading">LOADING...</div>
5554
<div *ngIf="technology" class="d-flex flex-column technology-content">
5655
<div
57-
*ngFor="let item of technology.items | filterProject: filterTechnology"
56+
*ngFor="let item of technology.items"
5857
(click)="setTechnology(item.name)"
5958
class="technology-list"
6059
[ngClass]="{ active: selectedTechnology.includes(item.name) }"
@@ -63,12 +62,10 @@
6362
</div>
6463
</div>
6564
<div class="tags-content d-flex flex-wrap">
66-
<span
67-
*ngFor="let technology of selectedTechnology; let tagIndex = index"
68-
(click)="removeTag(tagIndex)"
69-
class="tag"
70-
>{{ technology }}</span
71-
>
65+
<div *ngFor="let technology of selectedTechnology; let tagIndex = index" class="tag">
66+
<span class="mr-3">{{ technology }}</span>
67+
<i class="fas fa-times text-white" (click)="removeTag(tagIndex)"></i>
68+
</div>
7269
</div>
7370

7471
<div class="form-group">

src/app/modules/shared/components/details-fields/details-fields.component.scss

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
@mixin tagTechnology() {
44
background-color: $modal-button-secondary;
55
color: #ffffff;
6-
cursor: pointer;
76

87
&:hover {
98
opacity: 0.8;
@@ -31,12 +30,12 @@
3130
}
3231

3332
.technology-content {
34-
margin-bottom: 2rem;
33+
box-shadow: 0 3px 8px 0 rgba(0, 0, 0, 0.2), 0 0 0 1px rgba(0, 0, 0, 0.08);
34+
margin: 0 0 2rem 6rem;
3535
max-height: 7.5rem;
3636
overflow-y: auto;
3737

3838
.technology-list {
39-
background-color: #efefef;
4039
cursor: pointer;
4140
font-size: 0.8rem;
4241
margin-bottom: 0.1rem;
@@ -48,33 +47,25 @@
4847
}
4948

5049
.active {
51-
@include tagTechnology();
50+
background-color: #efefef;
5251
}
5352
}
5453

5554
.tags-content {
56-
margin-bottom: 2rem;
55+
margin: 2rem 0;
5756

58-
span {
57+
div {
5958
@include tagTechnology();
6059

6160
border-radius: 0.2rem;
6261
box-shadow: 2px 2px 5px 0px rgba(0, 0, 0, 0.75);
6362
font-size: 0.8rem;
64-
padding: 0 1rem 0.2rem 1.5rem;
63+
padding: 0.1rem 1rem 0.2rem 1.5rem;
6564
position: relative;
6665
margin: 0 0.5rem 0.5rem 0;
6766

68-
&::before {
69-
background: #fff;
70-
border-radius: 1rem;
71-
box-shadow: inset 0 1px rgba(0, 0, 0, 0.6);
72-
content: '';
73-
height: 0.4rem;
74-
left: 0.6rem;
75-
position: absolute;
76-
width: 0.4rem;
77-
top: 0.5rem;
67+
i {
68+
cursor: pointer;
7869
}
7970
}
8071
}

src/app/modules/shared/components/details-fields/details-fields.component.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ export class DetailsFieldsComponent implements OnChanges, OnInit {
1818
@ViewChild('closeModal') closeModal: ElementRef;
1919
entryForm: FormGroup;
2020
technology: Technology;
21-
filterTechnology = '';
2221
selectedTechnology: string[] = [];
2322
isLoading = false;
2423

0 commit comments

Comments
 (0)