fix: #48 implement semantic version #117
Conversation
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 92.30% 92.55% +0.24%
==========================================
Files 37 37
Lines 403 403
Branches 23 23
==========================================
+ Hits 372 373 +1
+ Misses 26 25 -1
Partials 5 5
Continue to review full report at Codecov.
|
| - name: Setup Node.js | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 12 |
There was a problem hiding this comment.
node version should be " node-version: '12.x' "
README.md
Outdated
|
|
||
| ## Code scaffolding | ||
|
|
||
| ## Commit format |
There was a problem hiding this comment.
Your text block is hurting the "code scaffolding" section please solve it.
I think your text block would fit better as another option of the menu "Prepare your environment".
Please change "Commit format" to "Commit message format"
| @@ -0,0 +1,22 @@ | |||
| name: Release | |||
There was a problem hiding this comment.
let's change it to:
bumping-versions-pipeline
README.md
Outdated
| ## Code scaffolding | ||
|
|
||
| ## Commit format | ||
| We are using format by release and tags: https://semver.org/ |
There was a problem hiding this comment.
A commit message needs to start with one of the following words to bump the application version properly (This application is following a semver strategy for versioning https://semver.org/)
README.md
Outdated
| - fix is equal to Patch Release example: 1.0.1 | ||
| - feat is equal to Feature Release example: 1.1.0 | ||
| - perf is equal to Breaking Release example: 2.0.0 |
There was a problem hiding this comment.
Let's mark the keywords in bold:
- fix is equal to Patch Release example: 1.0.1
- feat is equal to Feature Release example: 1.1.0
- perf is equal to Breaking Release example: 2.0.0
package.json
Outdated
| "pattern": "^(#([0-9]+).*)", | ||
| "errorMessage": "Your commit message must start with issue number e.g. #39" | ||
| "pattern": "^(fix: #|feat: #|perf: #)[0-9].*", | ||
| "errorMessage": "Your commit should has this format> fix or feat or perf: #45 message" |
There was a problem hiding this comment.
Your commit message needs to start with fix:, feat:, or perf: followed by issue number, e.g. fix: #43 any commit message
DiegoTinitana
force-pushed
the
48-implement-semantic-version
branch
from
b7bdedd to
23fa128
Compare
No description provided.