78 customer administration screens #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
- Coverage 92.55% 91.96% -0.59%
==========================================
Files 37 43 +6
Lines 403 386 -17
Branches 23 21 -2
==========================================
- Hits 373 355 -18
- Misses 25 26 +1
Partials 5 5
Continue to review full report at Codecov.
|
enriquezrene
suggested changes
Apr 13, 2020
src/app/app-routing.module.ts
Outdated
| children: [ | ||
| { path: 'reports', component: ReportsComponent }, | ||
| { path: 'time-clock', component: TimeClockComponent }, | ||
| { path: 'time-entries', component: TimeEntriesComponent }, | ||
| { path: 'project-management', component: ProjectManagementComponent }, | ||
| { path: 'activities-management', component: ActivitiesManagementComponent }, | ||
| {path: '', pathMatch: 'full', redirectTo: 'time-clock'}, | ||
| ] | ||
| { path: 'customer', component: CustomerComponent }, |
There was a problem hiding this comment.
path: 'customers-management'
src/app/app.module.ts
Outdated
| import { ManagmentCustomerProjectsComponent } from './modules/customer-managment/components/managment-customer-projects/managment-customer-projects.component'; | ||
| import { CreateCustomerComponent } from './modules/customer-managment/components/customer-info/components/create-customer/create-customer'; | ||
| // tslint:disable-next-line: max-line-length | ||
| import { CreateeProjectComponent } from './modules/customer-managment/components/projects/components/create-project/createe-project.component'; |
src/app/app.module.ts
Outdated
| import { CreateCustomerComponent } from './modules/customer-managment/components/customer-info/components/create-customer/create-customer'; | ||
| // tslint:disable-next-line: max-line-length | ||
| import { CreateeProjectComponent } from './modules/customer-managment/components/projects/components/create-project/createe-project.component'; | ||
| import { ProjectLiistComponent } from './modules/customer-managment/components/projects/components/project-liist/project-liist.component'; |
src/app/app.module.ts
Outdated
Comment on lines
86
to
87
| CreateeProjectComponent, | ||
| ProjectLiistComponent, |
| fixture.detectChanges(); | ||
| }); | ||
|
|
||
| it('should create', () => { |
There was a problem hiding this comment.
not should create but
it('component should be created', () => {
| export class SearchComponent implements OnInit { | ||
| constructor() {} | ||
|
|
||
| ngOnInit(): void {} |
Comment on lines
3
to
10
| .btn-primary { | ||
| background-image: $button-primary-color; | ||
| border: transparent; | ||
| } | ||
|
|
||
| .btn-hover:hover { | ||
| opacity: 0.8; | ||
| } |
| fixture.detectChanges(); | ||
| }); | ||
|
|
||
| it('should create', () => { |
There was a problem hiding this comment.
component should be created
|
|
||
| constructor() {} | ||
|
|
||
| ngOnInit(): void {} |
| { route: '/reports', icon: 'fas fa-chart-pie', text: 'Reports' }, | ||
| { route: '/project-management', icon: 'far fa-folder-open', text: 'Projects' }, | ||
| { route: '/activities-management', icon: 'far fa-file-alt', text: 'Activities' }, | ||
| { route: '/customer', icon: 'fas fa-users-cog', text: 'Customer' }, |
There was a problem hiding this comment.
let;s change this to customers-managent
…om/ioet/time-tracker-ui into 78-customers-administration-screen
enriquezrene
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR related to issue #78.