Skip to content

Close #94 Enforce authentication by JWT #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2020
Merged

Close #94 Enforce authentication by JWT #98

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a41ed7
feat: Ack JWT claims for authentication #94
Apr 22, 2020
7efc921
fix: Close #94 Fix tests to support authentication
Apr 22, 2020
be9fec2
fix: Ignore deleted-running time entry
Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Ignore deleted-running time entry
  • Loading branch information
EliuX committed Apr 22, 2020
commit be9fec2b59dc0a5c125c1156b057b61038b578f2
2 changes: 1 addition & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def running_time_entry(time_entry_repository: TimeEntryCosmosDBRepository,

yield created_time_entry

time_entry_repository.delete(id=created_time_entry.id,
time_entry_repository.delete_permanently(id=created_time_entry.id,
partition_key_value=tenant_id)


Expand Down
6 changes: 4 additions & 2 deletions time_tracker_api/time_entries/time_entries_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,11 @@ def find_running(self, partition_key_value: str, mapper: Callable = None):
result = self.container.query_items(
query="""
SELECT * from c
WHERE NOT IS_DEFINED(c.end_date) OR c.end_date = null
WHERE (NOT IS_DEFINED(c.end_date) OR c.end_date = null) {visibility_condition}
OFFSET 0 LIMIT 1
""",
""".format(
visibility_condition=self.create_sql_condition_for_visibility(True),
),
partition_key=partition_key_value,
max_item_count=1)

Expand Down