Close #94 Enforce authentication by JWT#98
Merged
Conversation
6f07527 to
7efc921
Compare
enriquezrene
approved these changes
Apr 22, 2020
Angeluz-07
approved these changes
Apr 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we are requiring authenticated users using JWT. To do so, we are using the library PyJWT, so in every request to the API we expect a header
Authorizationwith a format likeIf you want to check out the data (claims) that your JWT contains, you can also use the CLI of PyJWT:
Remember that the API is not verifying the authenticity of the JWT, but the API Management.
There is also an additional commit fixing most of our tests in order to adapt to these new requirements.