fix: #91 adding filter by attributes

[enriquezrene]

fix: #91 adding filter by attributes

[EliuX]

This implementation is not compliant with the format requested in the ticket for grouping the filter attributes.

[EliuX]

What if you have some query like this?

/activities?a=1&b=2&pageSize=0&orders["start_date"]="DESC"&limit=1

This is not going to work, because a and b are the attributes but you are filtering for whatever it is specified in the request arguments.

[EliuX]

In addition, it would be nice to filter per namespace that the attributes you want to filter by are valid.

[enriquezrene]

Good catch

[enriquezrene]

What if you have some query like this?

/activities?a=1&b=2&pageSize=0&orders["start_date"]="DESC"&limit=1

This is not going to work, because a and b are the attributes but you are filtering for whatever it is specified in the request arguments.

Do we have filtering and sorting arguments right now?

[EliuX]

The repository has sorting capabilities right now. For instance, The repository for time entries orders the results by start_date. We could do this dynamically in the future.

[EliuX]

Also, please rename the commit message.
Instead of fix, which is a patch, use feat, because you are adding a new feature.
For Github, you can use Fix or Close and the number of the issue. A final message for the commit could be:

feat: Close #91 Add filter by attributes to get all

This will increase the version with a minor update.

I should not approve my own changes