Serve swagger.json on UI over https #90
Conversation
|
|
||
|
|
||
| def add_proxy_fix_to_serve_swagger_over_https(app: Flask): | ||
| from werkzeug.middleware.proxy_fix import ProxyFix |
There was a problem hiding this comment.
I would call this function add_fixers and in the commit then I would say
Add ProxyFix to serve swagger over HTTPs.
This is supposed to be registered in the CHANGELOG and provide this node.
You can leave the logged message because it serves to explain what this particular fix is for.
There was a problem hiding this comment.
I agree with the commit message change. But I don't agree with the function name "add_fixers". It seems to general for me. This is a fix for a very specific problem. If later we found we need more fixers, it'll be ok to change the name to "add_fixers". But for now I think we are ok leaving the name of the function specific.
There was a problem hiding this comment.
Ok, but that function explains reasons and not what that actual function does. If you want to explain the reasons in a verbose way, better use a logger. But I understand your point on trying to be more specific, so I would name for instance use_werkzeug_proxy_fix, but whatever name with that idea in mind would do for me.
Angeluz-07
force-pushed
the
fix/swagger-not-working-in-https#47
branch
from
3269240 to
d315d5b
Compare
Fixes #47