Skip to content

Conversation

EliuX
Copy link
Contributor

@EliuX EliuX commented Mar 10, 2020

Creates the API definition for Time Entries, which are those created every time a user starts a new activity.

@EliuX EliuX force-pushed the feature/create-api-definition-time-entry#5 branch 2 times, most recently from f4f2fb8 to 3f627ce Compare March 11, 2020 14:50
title='Description',
description='Comments about the activity',
),

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a space here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refresh it, please :)

@@ -0,0 +1,132 @@
from flask_restplus import fields, Resource, Namespace

ns = Namespace('time_entries', description='API for time entries')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to change time_entries to time-entries as recommendation from https://restfulapi.net/resource-naming/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, my bad.

@EliuX EliuX force-pushed the feature/create-api-definition-time-entry#5 branch 2 times, most recently from 8f141e1 to 274566e Compare March 11, 2020 15:03
@EliuX EliuX force-pushed the feature/create-api-definition-time-entry#5 branch from 274566e to 2923b9c Compare March 11, 2020 15:21
@EliuX EliuX merged commit e775a26 into master Mar 11, 2020
@EliuX EliuX deleted the feature/create-api-definition-time-entry#5 branch March 11, 2020 15:53
@EliuX EliuX self-assigned this Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants