Apply code review suggestions

Author: EliuX

time_tracker_api/activities/activities_api.py

@@ -4,18 +4,28 @@
 
 # Activity Model
 activity = ns.model('Activity', {
-    'id': fields.String(readOnly=True, required=True, title='Identifier',
-                         description='The unique id of the activity'),
-    'name': fields.String(required=True, title='Name', max_length=50,
-                          description='Canonical name of the activity'),
-    'description': fields.String(title='Description',
-                                 description='Comments about the activity'),
-    'tenant_id': fields.String(required=True, title='Tenant', max_length=64,
-                               description='The tenant this belongs to')
+    'id': fields.String(
+        readOnly=True,
+        required=True,
+        title='Identifier',
+        description='The unique id of the activity'),
+    'name': fields.String(
+        required=True,
+        title='Name',
+        max_length=50,
+        description='Canonical name of the activity'),
+    'description': fields.String(
+        title='Description',
+        description='Comments about the activity'),
+    'tenant_id': fields.String(
+        required=True,
+        title='Tenant',
+        max_length=64,
+        description='The tenant this belongs to'),
 })
 
 
-@ns.route('/')
+@ns.route('')
 class Activities(Resource):
     @ns.doc('list_activities')
     @ns.marshal_list_with(activity, code=200)

time_tracker_api/time_entries/time_entry_api.py

@@ -4,39 +4,48 @@
 
 # TimeEntry Model
 time_entry = ns.model('TimeEntry', {
-    'id': fields.String(readOnly=True,
-                        required=True,
-                        title='Identifier',
-                        description='The unique id of the time entry'),
-    'project_id': fields.String(required=True,
-                                title='Project',
-                                max_length=64,
-                                description='The id of the selected project'),
-    'activity_id': fields.String(required=False,
-                                 title='Activity',
-                                 max_length=64,
-                                 description='The id of the selected activity'),
-    'technologies': fields.String(required=True,
-                                  title='Technologies',
-                                  max_length=64,
-                                  description='Canonical names of the used technologies during this period'),
-    'description': fields.String(title='Comments',
-                                 description='Comments about the time entry'),
-    'start_date': fields.DateTime(required=True,
-                                  title='Start date',
-                                  description='When the user started doing this activity'),
-    'end_date': fields.DateTime(required=True,
-                                title='End date',
-                                description='When the user ended doing this activity'),
+    'id': fields.String(
+        readOnly=True,
+        required=True,
+        title='Identifier',
+        description='The unique id of the time entry'),
+    'project_id': fields.String(
+        required=True,
+        title='Project',
+        max_length=64,
+        description='The id of the selected project'),
+    'activity_id': fields.String(
+        required=False,
+        title='Activity',
+        max_length=64,
+        description='The id of the selected activity'),
+    'technologies': fields.String(
+        required=True,
+        title='Technologies',
+        max_length=64,
+        description='Canonical names of the used technologies during this period'),
+    'description': fields.String(
+        title='Comments',
+        description='Comments about the time entry'),
+    'start_date': fields.DateTime(
+        required=True,
+        title='Start date',
+        description='When the user started doing this activity'),
+    'end_date': fields.DateTime(
+        required=True,
+        title='End date',
+        description='When the user ended doing this activity'),
 
-    'user_id': fields.String(required=True,
-                             title='Tenant',
-                             max_length=64,
-                             description='The user who created this time entry'),
-    'tenant_id': fields.String(required=True,
-                               title='Tenant',
-                               max_length=64,
-                               description='The tenant this time entry belongs to'),
+    'user_id': fields.String(
+        required=True,
+        title='Tenant',
+        max_length=64,
+        description='The user who created this time entry'),
+    'tenant_id': fields.String(
+        required=True,
+        title='Tenant',
+        max_length=64,
+        description='The tenant this time entry belongs to'),
 })
 
 time_entry_response = ns.inherit('TimeEntryResponse', time_entry, {
@@ -46,7 +55,7 @@
 })
 
 
-@ns.route('/')
+@ns.route('')
 class TimeEntries(Resource):
     @ns.doc('list_time_entries')
     @ns.marshal_list_with(time_entry_response, code=200)
@@ -88,7 +97,7 @@ def put(self, id):
         return ns.payload
 
 
-@ns.route('/stop/<string:id>')
+@ns.route('<string:id>/stop')
 @ns.response(404, 'Running time entry not found')
 @ns.param('id', 'The unique identifier of a running time entry')
 class StopTimeEntry(Resource):
@@ -99,7 +108,7 @@ def post(self, id):
         return None, 204
 
 
-@ns.route('/continue/<string:id>')
+@ns.route('<string:id>/continue')
 @ns.response(404, 'Stopped time entry not found')
 @ns.param('id', 'The unique identifier of a stopped time entry')
 class ContinueTimeEntry(Resource):