Skip to content

Fixes #64 - Update current models to meet new design. #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 3, 2020
Merged

Fixes #64 - Update current models to meet new design. #65

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
159dd08
Fixes #64 - Update current models to meet new design.
Angeluz-07 Apr 3, 2020
eca5943
Fixes #64 - update tests
Angeluz-07 Apr 3, 2020
d7b8191
Fixes #64 - apply PR observations
Angeluz-07 Apr 3, 2020
77a3f80
Fixes #64 - fix all ids to be of type UUID
Angeluz-07 Apr 3, 2020
03d46a3
Fixes #64 - fix ids type in TimeEntry
Angeluz-07 Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes #64 - update tests
  • Loading branch information
@Angeluz-07
Angeluz-07 committed Apr 3, 2020
commit eca594393fad5edae7dc0ea37a5776c11fa4e4da
3 changes: 2 additions & 1 deletion tests/activities/activities_namespace_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@

valid_activity_data = {
"name": fake.company(),
"description": fake.paragraph()
"description": fake.paragraph(),
"tenant_id": fake.uuid4()
}

fake_activity = ({
Expand Down
5 changes: 4 additions & 1 deletion tests/projects/projects_namespace_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,11 @@
valid_project_data = {
"name": fake.company(),
"description": fake.paragraph(),
"type": fake.word(PROJECT_TYPE.valid_type_values()),
'customer_id': fake.uuid4(),
'tenant_id': fake.uuid4(),
'project_type_id': fake.uuid4()
}

fake_project = ({
"id": fake.random_int(1, 9999)
}).update(valid_project_data)
Expand Down
7 changes: 4 additions & 3 deletions tests/time_entries/time_entries_namespace_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@
fake = Faker()

valid_time_entry_input = {
"project_id": fake.random_int(1, 9999),
"activity_id": fake.random_int(1, 9999),
"technologies": fake.words(3, ['java', 'javascript', 'python', 'azure'], unique=True),
"project_id": fake.uuid4(),
"activity_id": fake.uuid4(),
"description": fake.paragraph(nb_sentences=2),
"start_date": fake.iso8601(end_datetime=None),
"end_date": fake.iso8601(end_datetime=None),
"owner_id": fake.uuid4(),
Copy link
Contributor

@enriquezrene enriquezrene Apr 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model in LucidCharts has this field as owner only. @EliuX should we change the PR or update the LucidCharts diagram?

Copy link
Contributor

@EliuX EliuX Apr 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

"tenant_id": fake.uuid4()
}
fake_time_entry = ({
"id": fake.random_int(1, 9999),
Expand Down