Skip to content

feat: TT-353 Create V2 Activities DAO #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 4, 2021
Merged

feat: TT-353 Create V2 Activities DAO #320

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1065bde
feat: TT-353 Create V2 Activities DAO
Sep 24, 2021
3bb39b0
refactor: TT-353 Solving code smells from SonarCloud
Sep 24, 2021
b15c301
refactor: TT-353 Solving duplicated literal
Sep 24, 2021
7a2565c
refactor: TT-353 Add type of argument and return type to functions
Sep 27, 2021
8bdbdfe
refactor: TT-353 Solving comments from PR
Sep 29, 2021
bc998fe
refactor: TT-353 Solving Sonarcloud code smell
Sep 29, 2021
9d0e21e
refactor: TT-353 Changing variable names and tests
Sep 29, 2021
1f92569
refactor: TT-353 Solving requested changes on PR
Sep 30, 2021
04344ef
refactor: TT-353 Solving typo errors on names
Oct 1, 2021
48d6945
refactor: TT-353 Solving requested changes on PR
Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: TT-353 Solving code smells from SonarCloud
  • Loading branch information
Andrés Soto committed Sep 24, 2021
commit 3bb39b069da8dfade88b21e096333b4ab7a939db
2 changes: 1 addition & 1 deletion V2/source/daos/activities_json_dao.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def get_by_id(self, id):
activities = json.load(file)
file.close()

except FileNotFoundError as e:
except FileNotFoundError:
return HTTPStatus.NOT_FOUND

activity = next(
Expand Down
21 changes: 8 additions & 13 deletions V2/tests/daos/activities_json_dao_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ def test_get_by_id__return_activity_dto__when_find_activity_that_matches_its_id(
mocker,
):
activities_json_dao = ActivitiesJsonDao('non-important-path')
open_file = 'builtins.open'
activities = [
{
"name": "test_name",
Expand All @@ -22,9 +23,7 @@ def test_get_by_id__return_activity_dto__when_find_activity_that_matches_its_id(
read_data = json.dumps(activities)
activity_dto = ActivityDto(**activities.pop())

open_file_mock = mocker.patch(
'builtins.open', mocker.mock_open(read_data=read_data)
)
mocker.patch(open_file, mocker.mock_open(read_data=read_data))

result = activities_json_dao.get_by_id(activity_dto.id)

Expand All @@ -35,13 +34,11 @@ def test__get_by_id__return_httpstatus_not_found__when_no_activity_matches_its_i
mocker,
):
activities_json_dao = ActivitiesJsonDao('non-important-path')

open_file = 'builtins.open'
activity = []
read_data = json.dumps(activity)

open_file_mock = mocker.patch(
'builtins.open', mocker.mock_open(read_data=read_data)
)
mocker.patch(open_file, mocker.mock_open(read_data=read_data))

result = activities_json_dao.get_by_id('non-important-id')

Expand All @@ -52,6 +49,7 @@ def test_get_all__return_list_of_activity_dto__when_find_one_or_more_activities(
mocker,
):
activities_json_dao = ActivitiesJsonDao('non-important-path')
open_file = 'builtins.open'
activity = {
"name": "test_name",
"description": "test_description",
Expand All @@ -68,9 +66,7 @@ def test_get_all__return_list_of_activity_dto__when_find_one_or_more_activities(
activities = [activity] * number_of_activities
read_data = json.dumps(activities)

open_file_mock = mocker.patch(
'builtins.open', mocker.mock_open(read_data=read_data)
)
mocker.patch(open_file, mocker.mock_open(read_data=read_data))

result = activities_json_dao.get_all()

Expand All @@ -79,13 +75,12 @@ def test_get_all__return_list_of_activity_dto__when_find_one_or_more_activities(

def test_get_all__return_empty_list__when_doesnt_found_any_activities(mocker):
activities_json_dao = ActivitiesJsonDao('non-important-path')
open_file = 'builtins.open'
activities = []

read_data = json.dumps(activities)

open_file_mock = mocker.patch(
'builtins.open', mocker.mock_open(read_data=read_data)
)
mocker.patch(open_file, mocker.mock_open(read_data=read_data))

result = activities_json_dao.get_all()

Expand Down