Skip to content

Conversation

@EdansRocks
Copy link
Contributor

Description

With this PR the V2 directory was created for the new version of the Time Tracker backend, according to the structure defined by the team. In addition, the DAO was created to access the activity data from a JSON format file, as well as its service. The architecture taken into account can be seen below:

image

@eguezgustavo
Copy link

@EdansRocks puedes por fa agregarle typing a los argumentos de las funciones y al valor que retornan?

Copy link
Collaborator

@josepato87 josepato87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josepato87 josepato87 self-requested a review September 28, 2021 20:43
Copy link
Collaborator

@josepato87 josepato87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@EdansRocks EdansRocks merged commit 328ad43 into master Oct 4, 2021
@EdansRocks EdansRocks deleted the TT-353-Create-V2-Activities-DAO branch October 4, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants