fix: TT-302 Fix dependencies vulnerabilities #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
jcalarcon98
requested review from
bytesantiago,
edgardavid2015,
JosueOb,
kevinjlope,
PieritoAlva95 and
scastillo-jp
bytesantiago
approved these changes
Jul 29, 2021
ridouku
approved these changes
Jul 29, 2021
scastillo-jp
approved these changes
Aug 3, 2021
edgardavid2015
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we need to upgrade urllib3 to version 1.26.5 or later. Because earlier versions allows CRLF injection if the attacker controls the HTTP request method, The problem is that another package (
request==2.23.0) needsurllib3==1.25.8Solution
The issue has been fixed in urllib3 v1.26.5, so we upgrade urllib3 to that version and we also upgrade request package to
2.25.1