Skip to content

feat: TT 243 Refactor functions on time entries repository #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 11, 2021
Merged

feat: TT 243 Refactor functions on time entries repository #298

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
24971dc
feat: TT-243 Add functions and testing to base query builder
jcalarcon98 Jun 4, 2021
91d13b2
feat: TT-243 Add function and testing to time entries query builder
jcalarcon98 Jun 4, 2021
fb3900d
feat: TT-243 Refactor find_running and find_interception_with_date_ra…
jcalarcon98 Jun 4, 2021
1febce8
feat: TT-243 Add current datetime if end_date is None
jcalarcon98 Jun 4, 2021
0681d3b
feat: TT-243 Fixing code smells
jcalarcon98 Jun 4, 2021
bad6ee2
feat: TT-243 Improve code quality by fixing code smells
jcalarcon98 Jun 4, 2021
498a643
feat: TT-243 Refactor code based on PR reviews
jcalarcon98 Jun 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: TT-243 Improve code quality by fixing code smells
  • Loading branch information
@jcalarcon98
jcalarcon98 committed Jun 9, 2021
commit bad6ee2aa307173d00463f9c0f3eb30836abaf0e
12 changes: 6 additions & 6 deletions tests/time_tracker_api/time_entries/time_entries_query_builder_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ def test_build_with_add_sql_date_range_condition():
TimeEntryQueryBuilder()
.add_sql_date_range_condition(
{
"start_date": "2021-03-19T05:00:00.000Z",
"end_date": "2021-03-20T10:00:00.000Z",
"start_date": "2021-04-19T05:00:00.000Z",
"end_date": "2021-04-20T10:00:00.000Z",
}
)
.build()
Expand All @@ -60,8 +60,8 @@ def test_build_with_add_sql_date_range_condition():


def test_add_sql_interception_with_date_range_condition():
start_date = "2021-03-19T05:07:00.000Z"
end_date = "2021-03-25T10:00:00.000Z"
start_date = "2021-01-19T05:07:00.000Z"
end_date = "2021-01-25T10:00:00.000Z"

time_entry_query_builder = (
TimeEntryQueryBuilder().add_sql_interception_with_date_range_condition(
Expand All @@ -80,8 +80,8 @@ def test_add_sql_interception_with_date_range_condition():


def test_build_with_add_sql_interception_with_date_range_condition():
start_date = "2021-03-19T05:07:00.000Z"
end_date = "2021-03-25T10:00:00.000Z"
start_date = "2021-02-19T05:07:00.000Z"
end_date = "2021-02-25T10:00:00.000Z"
time_entry_query_builder = (
TimeEntryQueryBuilder()
.add_sql_interception_with_date_range_condition(start_date, end_date)
Expand Down