feat: TT 243 Refactor functions on time entries repository #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcalarcon98
requested review from
jase156,
kevinjlope,
lenshinoda,
pfsolorzanos and
scastillo-jp
scastillo-jp
approved these changes
Jun 7, 2021
scastillo-jp
approved these changes
Jun 8, 2021
Angeluz-07
reviewed
Jun 8, 2021
Angeluz-07
reviewed
Jun 8, 2021
Angeluz-07
reviewed
Jun 8, 2021
Angeluz-07
reviewed
Jun 8, 2021
Angeluz-07
reviewed
Jun 8, 2021
Angeluz-07
reviewed
Jun 8, 2021
Angeluz-07
reviewed
Jun 8, 2021
Contributor
Angeluz-07
left a comment
Angeluz-07
left a comment
There was a problem hiding this comment.
Good job. Please check my comments and update tests accordingly.
jcalarcon98
force-pushed
the
TT-243-refactor-functions-time-entries-repository
branch
from
da0564d to
498a643
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jcalarcon98
deleted the
TT-243-refactor-functions-time-entries-repository
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In time_entries_repository.py file. it would be necessary to make a code refactoring in
find_interception_with_date_rangeandfind_runningfunctions, in order to use a Query Builder for query building.