Tt 98 toogles backend #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

PaulRC-ioet merged 7 commits into master from TT-98-toogles-backend

Jan 11, 2021

Contributor

PaulRC-ioet commented Jan 8, 2021

Implementation of feature toggles in the backend.

PaulRC-ioet added 4 commits

January 7, 2021 11:30


          TT-98 feat: add feature flags

89f6c51


          TT-98 fix: refactor feature toggle manager

71e7ed4


          TT-98 feat: Add test to feature toggle manager file

384f37c


          TT-98 fix: refactor code in feature toggles file

6cde781

PaulRC-ioet requested review from Angeluz-07, enriquezrene, israteneda, josepato87 and scastillo-jp

January 8, 2021 21:05

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_namespace.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

tests/commons/feature_toggles/feature_toggles_manager_test.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

commons/feature_toggles/feature_toggle_manager.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

commons/feature_toggles/feature_toggle_manager.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

commons/feature_toggles/feature_toggle_manager.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

commons/feature_toggles/feature_toggle_manager.py Outdated Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

commons/feature_toggles/feature_toggle_manager.py Show resolved Hide resolved

Angeluz-07 reviewed

View reviewed changes

Contributor

Angeluz-07 left a comment

Some comments. I must say that we need to also update the .env.example file with our new env variable.

PaulRC-ioet added 2 commits

January 8, 2021 18:18


          TT-98 fix: upgrate version of azure core

f3e7109


          TT-98 fix: refactor comments made by Roberto

036c8db

Angeluz-07 force-pushed the TT-98-toogles-backend branch from 5929554 to 036c8db Compare

January 11, 2021 18:08

Angeluz-07 reviewed

View reviewed changes

time_tracker_api/time_entries/time_entries_namespace.py Outdated Show resolved Hide resolved


          TT-98 fix: remove import in time_entries_namespaces

14b377d

Angeluz-07 approved these changes

View reviewed changes

PaulRC-ioet merged commit 49f601f into master

PaulRC-ioet deleted the TT-98-toogles-backend branch

January 11, 2021 20:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

enriquezrene Awaiting requested review from enriquezrene

scastillo-jp Awaiting requested review from scastillo-jp

josepato87 Awaiting requested review from josepato87

israteneda Awaiting requested review from israteneda

1 more reviewer

Angeluz-07 Angeluz-07 approved these changes

Labels

None yet