TT-98 fix: refactor comments made by Roberto

Author: PaulRC-ioet

.env.template

@@ -20,3 +20,4 @@ export MS_CLIENT_ID=
 export MS_SCOPE=
 export MS_SECRET=
 export MS_ENDPOINT=
+export AZURE_APP_CONFIGURATION_CONNECTION_STRING=

commons/feature_toggles/feature_toggle_manager.py

@@ -4,14 +4,15 @@
 from azure.appconfiguration import AzureAppConfigurationClient
 
 
-class MSConfig:
+class FeatureToggleConfig:
     def check_variables_are_defined():
-        auth_variables = ['AZURE_APP_CONFIGURATION_CONNECTION_STRING']
-        for var in auth_variables:
-            if var not in os.environ:
-                raise EnvironmentError(
-                    "{} is not defined in the environment".format(var)
+        azure_app_variable = 'AZURE_APP_CONFIGURATION_CONNECTION_STRING'
+        if azure_app_variable not in os.environ:
+            raise EnvironmentError(
+                "{} is not defined in the environment".format(
+                    azure_app_variable
                 )
+            )
 
     check_variables_are_defined()
     AZURE_APP_CONFIGURATION_CONNECTION_STRING = os.environ.get(
@@ -20,12 +21,13 @@ def check_variables_are_defined():
 
 
 class FeatureToggleManager:
-    def __init__(self, key: str, label: str = None, config=MSConfig):
+    def __init__(
+        self, key: str, label: str = None, config=FeatureToggleConfig
+    ):
         self.key = key
         self.label = label
         self.config = config
         self.client = self.get_azure_app_configuration_client()
-        self.configuration = {}
 
     def get_azure_app_configuration_client(self):
         connection_str = self.config.AZURE_APP_CONFIGURATION_CONNECTION_STRING
@@ -37,14 +39,16 @@ def get_azure_app_configuration_client(self):
 
     def get_configuration(self, key: str, label: str):
         configuration = self.client.get_configuration_setting(
-            key=f".appconfig.featureflag/{self.key}", label=self.label
+            key=f".appconfig.featureflag/{key}", label=label
         )
 
         return configuration
 
     def get_data_configuration(self):
-        self.configuration = self.get_configuration(self.key, self.label)
-        result = json.loads(self.configuration.value)
+        feature_data_configuration = self.get_configuration(
+            self.key, self.label
+        )
+        result = json.loads(feature_data_configuration.value)
 
         return result
 

tests/commons/feature_toggles/feature_toggles_manager_test.py

@@ -3,7 +3,7 @@
 from pytest import mark
 
 
-def mock_payload(enabled, user):
+def mock_feature_toggle_config_response(enabled, user):
     return {
         "id": "test-feature-toggle",
         "description": "Feature Toggle test Backend",
@@ -54,8 +54,10 @@ def test_if_is_toggle_enabled_for_user(
 ):
     current_user_email_mock.return_value = currrent_user_email
     feature_toggle_manager = FeatureToggleManager("test-feature-toggle")
-    feature_toggle_manager.get_data_configuration.return_value = mock_payload(
-        is_toggle_enabled, user_email_enabled
+    feature_toggle_manager.get_data_configuration.return_value = (
+        mock_feature_toggle_config_response(
+            is_toggle_enabled, user_email_enabled
+        )
     )
 
     assert (

time_tracker_api/time_entries/time_entries_namespace.py

@@ -268,24 +268,6 @@ def get(self):
         return time_entries_dao.get_lastest_entries_by_project(conditions={})
 
 
-@ns.route('/feature-toggles')
-class FeaturesToggles(Resource):
-    @ns.doc('feature_toggle_tests')
-    @ns.marshal_list_with(time_entry)
-    @ns.response(HTTPStatus.NOT_FOUND, 'No time entries found')
-    def get(self):
-        """Test Feature Toggles"""
-        featureTest = FeatureToggleManager("ui-list-test-users")
-        test = featureTest.is_toggle_enabled_for_user()
-        if test:
-            return time_entries_dao.get_lastest_entries_by_project(
-                conditions={}
-            )
-        else:
-            conditions = attributes_filter.parse_args()
-            return time_entries_dao.get_all(conditions=conditions)
-
-
 @ns.route('/<string:id>')
 @ns.response(HTTPStatus.NOT_FOUND, 'This time entry does not exist')
 @ns.response(HTTPStatus.UNPROCESSABLE_ENTITY, 'The id has an invalid format')