229 make admin #235
Merged
229 make admin #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magallegos1996
requested review from
Angeluz-07,
PaulRC-ioet,
josepato87 and
scastillo-jp
scastillo-jp
approved these changes
Nov 13, 2020
Angeluz-07
suggested changes
Nov 13, 2020
scastillo-jp
approved these changes
Nov 13, 2020
PaulRC-ioet
approved these changes
Nov 13, 2020
josepato87
approved these changes
Nov 13, 2020
enriquezrene
suggested changes
Nov 14, 2020
Angeluz-07
force-pushed
the
229_make_admin
branch
from
25c3127 to
8299329
Compare
enriquezrene
approved these changes
Nov 16, 2020
juanultimate
suggested changes
Nov 16, 2020
…d with expected arguments #229
Angeluz-07
force-pushed
the
229_make_admin
branch
from
269dab6 to
67ce20b
Compare
juanultimate
approved these changes
Nov 21, 2020
|
|
||
|
|
||
| @ns.route('/<string:user_id>/roles/<string:role_id>') | ||
| @ns.response(HTTPStatus.NOT_FOUND, 'User not found') |
There was a problem hiding this comment.
User not found? IMO, it is better to say Role not found
|
|
||
| @ns.route('/<string:id>') | ||
| @ns.route('/<string:id>/roles') | ||
| @ns.response(HTTPStatus.NOT_FOUND, 'User not found') |
There was a problem hiding this comment.
User not found? I would say it is better to say Role not found
| @ns.doc('create_user_role') | ||
| @ns.expect(user_role_input_fields) | ||
| @ns.response( | ||
| HTTPStatus.BAD_REQUEST, 'Invalid format or structure of the user' |
There was a problem hiding this comment.
Invalid format or structure of the user? Is not this for roles?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.