feat: update url #229

Author: Angeluz-07

tests/time_tracker_api/users/users_namespace_test.py

@@ -6,18 +6,14 @@
 
 
 def test_users_response_contains_expected_props(
-    client: FlaskClient,
-    valid_header: dict,
+    client: FlaskClient, valid_header: dict,
 ):
 
     AzureConnection.users = Mock(
         return_value=[{'name': 'dummy', 'email': 'dummy', 'role': 'dummy'}]
     )
 
-    response = client.get(
-        '/users',
-        headers=valid_header,
-    )
+    response = client.get('/users', headers=valid_header,)
 
     assert HTTPStatus.OK == response.status_code
     assert 'name' in json.loads(response.data)[0]
@@ -26,17 +22,17 @@ def test_users_response_contains_expected_props(
 
 
 def test_update_user_role_response_contains_expected_props(
-    client: FlaskClient,
-    valid_header: dict,
-    user_id: str,
+    client: FlaskClient, valid_header: dict, user_id: str,
 ):
     valid_user_role_data = {'role': 'admin'}
     AzureConnection.update_user_role = Mock(
         return_value={'name': 'dummy', 'email': 'dummy', 'role': 'dummy'}
     )
 
     response = client.put(
-        f'/users/{user_id}', headers=valid_header, json=valid_user_role_data
+        f'/users/{user_id}/roles',
+        headers=valid_header,
+        json=valid_user_role_data,
     )
 
     assert HTTPStatus.OK == response.status_code
@@ -55,7 +51,9 @@ def test_update_user_role_is_being_called_with_valid_arguments(
 
     valid_user_role_data = {'role': 'admin'}
     response = client.put(
-        f'/users/{user_id}', headers=valid_header, json=valid_user_role_data
+        f'/users/{user_id}/roles',
+        headers=valid_header,
+        json=valid_user_role_data,
     )
 
     assert HTTPStatus.OK == response.status_code

time_tracker_api/users/users_namespace.py

@@ -62,25 +62,19 @@ def get(self):
         return azure_connection.users()
 
 
-@ns.route('/<string:id>')
+@ns.route('/<string:id>/roles')
 @ns.response(HTTPStatus.NOT_FOUND, 'User not found')
 @ns.response(HTTPStatus.UNPROCESSABLE_ENTITY, 'The id has an invalid format')
 @ns.param('id', 'The user identifier')
-class User(Resource):
-    @ns.doc('get_user')
-    @ns.marshal_with(user_response_fields)
-    def get(self, id):
-        """Get an user"""
-        return {}
-
-    @ns.doc('update_user')
+class UserRole(Resource):
+    @ns.doc('update_user_role')
     @ns.expect(user_input_fields)
     @ns.response(
         HTTPStatus.BAD_REQUEST, 'Invalid format or structure of the user'
     )
     @ns.marshal_with(user_response_fields)
     def put(self, id):
-        """Update an user"""
+        """Update user's role"""
         from utils.azure_users import AzureConnection
 
         azure_connection = AzureConnection()