Skip to content

Ref/move custom modules to utils folder#147 #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 21, 2020
Merged

Ref/move custom modules to utils folder#147 #149

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8e0d123
refactor: :truck: move custom modules to utils folder
Angeluz-07 May 20, 2020
b6476e2
refactor: :recycle: replace peeker logic
Angeluz-07 May 20, 2020
a6b6f91
refactor: :recycle: make validation functions of repository as instan…
Angeluz-07 May 20, 2020
4f90d37
refactor: :recycle: remove log statement
Angeluz-07 May 20, 2020
e794d3b
refactor: :recycle: rename long named tests
Angeluz-07 May 21, 2020
449623f
refactor: :ok_hand: add docs to utils.extend_model.py
Angeluz-07 May 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: ♻️ rename long named tests
  • Loading branch information
@Angeluz-07
Angeluz-07 committed May 21, 2020
commit e794d3bf78e92706ce2b4f1ef167f2bad31da4d6
39 changes: 22 additions & 17 deletions tests/time_tracker_api/time_entries/time_entries_namespace_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
fake_time_entry.update(valid_time_entry_input)


def test_create_time_entry_with_invalid_date_range_should_raise_bad_request_error(
def test_create_time_entry_with_invalid_date_range_should_raise_bad_request(
client: FlaskClient, mocker: MockFixture, valid_header: dict
):
from time_tracker_api.time_entries.time_entries_namespace import (
Expand All @@ -63,7 +63,7 @@ def test_create_time_entry_with_invalid_date_range_should_raise_bad_request_erro
repository_container_create_item_mock.assert_not_called()


def test_create_time_entry_with_end_date_in_future_should_raise_bad_request_error(
def test_create_time_entry_with_end_date_in_future_should_raise_bad_request(
client: FlaskClient, mocker: MockFixture, valid_header: dict
):
from time_tracker_api.time_entries.time_entries_namespace import (
Expand Down Expand Up @@ -180,30 +180,35 @@ def test_get_time_entry_should_succeed_with_valid_id(
dao_get_mock.assert_called_once_with(str(valid_id))


def test_get_time_entry_should_response_with_unprocessable_entity_for_invalid_id_format(
client: FlaskClient, mocker: MockFixture, valid_header: dict
@pytest.mark.parametrize(
'http_exception,http_status',
[
(NotFound, HTTPStatus.NOT_FOUND),
(UnprocessableEntity, HTTPStatus.UNPROCESSABLE_ENTITY),
],
)
def test_get_time_entry_raise_http_exception(
client: FlaskClient,
mocker: MockFixture,
valid_header: dict,
valid_id: str,
http_exception: HTTPException,
http_status: tuple,
):
from time_tracker_api.time_entries.time_entries_namespace import (
time_entries_dao,
)
from werkzeug.exceptions import UnprocessableEntity

invalid_id = fake.word()

repository_find_mock = mocker.patch.object(
time_entries_dao.repository, 'find', side_effect=UnprocessableEntity
)
time_entries_dao.repository.find = Mock(side_effect=http_exception)

response = client.get(
"/time-entries/%s" % invalid_id,
f"/time-entries/{valid_id}",
headers=valid_header,
follow_redirects=True,
)

assert HTTPStatus.UNPROCESSABLE_ENTITY == response.status_code
repository_find_mock.assert_called_once_with(
str(invalid_id), ANY,
)
assert http_status == response.status_code
time_entries_dao.repository.find.assert_called_once_with(valid_id, ANY)


def test_update_time_entry_calls_partial_update_with_incoming_payload(
Expand Down Expand Up @@ -243,7 +248,7 @@ def test_update_time_entry_should_reject_bad_request(

invalid_time_entry_data = valid_time_entry_input.copy()
invalid_time_entry_data.update(
{"project_id": fake.pyint(min_value=1, max_value=100),}
{"project_id": fake.pyint(min_value=1, max_value=100)}
)
repository_update_mock = mocker.patch.object(
time_entries_dao.repository, 'update', return_value=fake_time_entry
Expand Down Expand Up @@ -487,7 +492,7 @@ def test_get_running_should_call_find_running(
repository_update_mock.assert_called_once_with(tenant_id, owner_id)


def test_get_running_should_return_not_found_if_find_running_throws_StopIteration(
def test_get_running_should_return_not_found_if_StopIteration(
client: FlaskClient,
mocker: MockFixture,
valid_header: dict,
Expand Down