Ref/move custom modules to utils folder#147 #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I include changes that Fixes #147 . Changes related to this are in utils/extend_model.py and utils/worked_time.py
Also included a refactor of the parameter peeker in the find_all method of CosmosDBRepository class. This had the purpose to send a validation function from a high level class to a low level class. This function was running logic that would be better understood if applied in the high level class. Also, eventually we would need to run more than one validation function. With the current changes I pretend make this validation functions easy to modify and debug. This has been discussed with @fabidick22 previously and we agreed on it.
Changes related to remove the peeker parameter are in the files cosmos_db.py, time_entries_model.py. Test were updated to meet this changes, in time_entries_namespace_test.py.
The rest of files were only formatted automatically by our new commit hook.