Skip to content

Create Azure functions project time tracker events #53 #101 #102 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 30, 2020
Merged

Create Azure functions project time tracker events #53 #101 #102 #119

merged 7 commits into from
Apr 30, 2020

Conversation

@EliuX
Copy link
Contributor

@EliuX EliuX commented Apr 30, 2020

This PR solves the issues #53, #101 and #102. In addition it also adds the following fixes:

  • Implements an event context in order to group better the data manipulation in the data access layer.
  • Verifies whether a time entry is already running before restarting it. If so, it throws a 422.
  • Verifies whether a time entry is already stopped before stopping it. If so, it throws a 422.

@EliuX EliuX added the enhancement New feature or request label Apr 30, 2020
@EliuX EliuX self-assigned this Apr 30, 2020
@EliuX EliuX force-pushed the feature/add-proj-time-tracker-events#101 branch from 6c63744 to 46b91fa Compare April 30, 2020 18:29
Angeluz-07
Angeluz-07 reviewed Apr 30, 2020
View reviewed changes
@EliuX EliuX force-pushed the feature/add-proj-time-tracker-events#101 branch 3 times, most recently from 466e572 to 25c2ad6 Compare April 30, 2020 19:31
Angeluz-07
Angeluz-07 reviewed Apr 30, 2020
View reviewed changes
@EliuX EliuX force-pushed the feature/add-proj-time-tracker-events#101 branch from 25c2ad6 to e61a887 Compare April 30, 2020 20:01
@EliuX EliuX force-pushed the feature/add-proj-time-tracker-events#101 branch from e61a887 to b6ab54d Compare April 30, 2020 20:23
@EliuX EliuX merged commit 1aa8afd into master Apr 30, 2020
@EliuX EliuX deleted the feature/add-proj-time-tracker-events#101 branch April 30, 2020 20:24
This was referenced May 4, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@enriquezrene enriquezrene enriquezrene approved these changes

@Angeluz-07 Angeluz-07 Angeluz-07 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@EliuX EliuX

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EliuX @enriquezrene @Angeluz-07