Skip to content

Fix: Azure endpoint return all users from ioet #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cxcarvaj merged 6 commits into from
Feb 16, 2022
Merged

Fix: Azure endpoint return all users from ioet #80

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
67c6f70
Fix: Azure endpoint return all users from ioet
cxcarvaj Feb 16, 2022
504a0f3
Fix: Azure endpoint return all users from ioet
cxcarvaj Feb 16, 2022
55a06c2
refactor: Refactor of code smells
cxcarvaj Feb 16, 2022
bbf68f2
style: Changes requested by review
cxcarvaj Feb 16, 2022
2a1dc12
style: Changes requested by reviews
cxcarvaj Feb 16, 2022
462117f
style: Changes requested by Sandros review
cxcarvaj Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: Changes requested by review
  • Loading branch information
@cxcarvaj
cxcarvaj committed Feb 16, 2022
commit bbf68f268363d4d87a9f6fc8dc0854b292df2ff9
9 changes: 5 additions & 4 deletions nodejs-functions/src/handlers/automatic-clock-outs/clock_out.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const doClockOut = async (context) => {
await Promise.all(
entries.map(async (timeEntryAsJson) => {
const timeEntry = new TimeEntry(timeEntryAsJson);
const { userName, userEmail } = findUserData( users, timeEntry.timeEntry.owner_id);
const { userName, userEmail } = findUserData(users, timeEntry.timeEntry.owner_id);
const userId = findSlackUserId(slackUsers, userEmail);

if (timeEntry.needsToBeClockedOut()) {
Expand All @@ -38,10 +38,11 @@ const doClockOut = async (context) => {
timeEntryAsJson.end_date = timeEntry.getTimeToClockOut();
await container.item(timeEntryAsJson.id, timeEntryAsJson.tenant_id).replace(timeEntryAsJson);
totalClockOutsExecuted++;

} else if (timeEntry.needsToBeClockedOutMidnight()) {
}

else if (timeEntry.needsToBeClockedOutMidnight()) {
if (userId) {
SlackClient.sendMessageToUser(userId,CLOCK_OUT_MESSAGE_MIDNIGHT.replace('%user_name%', userName));
SlackClient.sendMessageToUser(userId, CLOCK_OUT_MESSAGE_MIDNIGHT.replace('%user_name%', userName));
}
timeEntryAsJson.end_date = timeEntry.getTimeToClockOutMidnight();
await container.item(timeEntryAsJson.id, timeEntryAsJson.tenant_id).replace(timeEntryAsJson);
Expand Down