Skip to content

Fix: Azure endpoint return all users from ioet #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 16, 2022
Merged

Fix: Azure endpoint return all users from ioet #80

merged 6 commits into from
Feb 16, 2022

Conversation

cxcarvaj
Copy link
Contributor

No description provided.

madinya
madinya reviewed Feb 16, 2022
View reviewed changes
madinya
madinya reviewed Feb 16, 2022
View reviewed changes
madinya
madinya reviewed Feb 16, 2022
View reviewed changes
madinya
madinya reviewed Feb 16, 2022
View reviewed changes
Copy link

@madinya madinya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I left some comments to clarify prior the approve. Also it could be better if it can be checked by Sandro if it was not already reviewed.

@scastillo-jp scastillo-jp self-requested a review February 16, 2022 15:04
scastillo-jp
scastillo-jp reviewed Feb 16, 2022
View reviewed changes
heikergil
heikergil approved these changes Feb 16, 2022
View reviewed changes
Copy link

@heikergil heikergil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

scastillo-jp
scastillo-jp approved these changes Feb 16, 2022
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

heikergil
heikergil approved these changes Feb 16, 2022
View reviewed changes
Copy link

@heikergil heikergil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

madinya
madinya approved these changes Feb 16, 2022
View reviewed changes
Copy link

@madinya madinya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cxcarvaj cxcarvaj merged commit b54e61a into master Feb 16, 2022
@cxcarvaj cxcarvaj mentioned this pull request Feb 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scastillo-jp scastillo-jp scastillo-jp approved these changes

+2 more reviewers

@madinya madinya madinya approved these changes

@heikergil heikergil heikergil approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cxcarvaj @madinya @scastillo-jp @heikergil