-
Notifications
You must be signed in to change notification settings - Fork 0
feat: TT-184 Slack nick name send a personal message to users #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TT-184 Slack nick name send a personal message to users #44
Conversation
Angeluz-07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I missed something. Why do we have files with duplicated logic?. AutomaticClockOuts/ and nodejs-functions/src/handlers/automatic-clock-outs/.
Also, check if you really need to push the file nodejs-functions/.serverless/nodejs-functions.zip It seems it is not necessary.
These files were added with the serveless migration and have the same logic, as the AutomaticClockOuts/, I am not sure if the CI is implemented and with that I only have to change certain files and which files these would be, I think @diegotony may have more information about it. |
b65ceb9 to
f2773f2
Compare
@Angeluz-07 I removed unnecessary |
04b3f4e to
bd85f10
Compare
Angeluz-07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job!
Add personal message to users , refactor the message to public channel