Skip to content

Conversation

@LEON12699
Copy link
Member

Add personal message to users , refactor the message to public channel

Copy link

@Angeluz-07 Angeluz-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I missed something. Why do we have files with duplicated logic?. AutomaticClockOuts/ and nodejs-functions/src/handlers/automatic-clock-outs/.

Also, check if you really need to push the file nodejs-functions/.serverless/nodejs-functions.zip It seems it is not necessary.

@LEON12699
Copy link
Member Author

Maybe I missed something. Why do we have files with duplicated logic?. AutomaticClockOuts/ and nodejs-functions/src/handlers/automatic-clock-outs/.

Also, check if you really need to push the file nodejs-functions/.serverless/nodejs-functions.zip It seems it is not necessary.

These files were added with the serveless migration and have the same logic, as the AutomaticClockOuts/, I am not sure if the CI is implemented and with that I only have to change certain files and which files these would be, I think @diegotony may have more information about it.

@LEON12699 LEON12699 force-pushed the TT-184-Slack-send-personal-message-to-users branch from b65ceb9 to f2773f2 Compare March 17, 2021 21:01
@LEON12699
Copy link
Member Author

Maybe I missed something. Why do we have files with duplicated logic?. AutomaticClockOuts/ and nodejs-functions/src/handlers/automatic-clock-outs/.
Also, check if you really need to push the file nodejs-functions/.serverless/nodejs-functions.zip It seems it is not necessary.

These files were added with the serveless migration and have the same logic, as the AutomaticClockOuts/, I am not sure if the CI is implemented and with that I only have to change certain files and which files these would be, I think @diegotony may have more information about it.

@Angeluz-07 I removed unnecessary nodejs-functions/.serverless/nodejs-functions.zip, @diegotony told me to update both copies

@LEON12699 LEON12699 force-pushed the TT-184-Slack-send-personal-message-to-users branch from 04b3f4e to bd85f10 Compare March 17, 2021 23:51
@LEON12699 LEON12699 requested a review from scastillo-jp March 18, 2021 15:06
Copy link

@Angeluz-07 Angeluz-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

@scastillo-jp scastillo-jp merged commit 6bbfc1b into master Mar 19, 2021
@diegotony diegotony deleted the TT-184-Slack-send-personal-message-to-users branch April 1, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants