feat: TT-184 add spaces, move channel id to -env

Author: LEON12699

AutomaticClockOuts/clock_out.js

@@ -5,13 +5,13 @@ const TimeEntry = require('./time_entry');
 const MsalClient = require('./msal_client');
 const TimeEntryDao = require('./time_entry_dao');
 const SlackClient = require('./slack_client');
-const { ClockOutMessage } = require('./constants');
+const { CLOCK_OUT_MESSAGE } = require('./constants');
 
 const doClockOut = async (context) => {
   context.log(`I am going to check how many entries were not clocked out ${new Date()}`);
 
   const { endpoint, key, databaseId } = config;
-  const client = new CosmosClient({endpoint, key});
+  const client = new CosmosClient({ endpoint, key});
   const database = client.database(databaseId);
   const container = database.container('time_entry');
   const timeEntryDao = new TimeEntryDao(database);
@@ -33,15 +33,15 @@ const doClockOut = async (context) => {
       const userId = findSlackUserId(slackUsers, user_email);
       if(userId){
         usersWithClockOut.push("<@"+userId+">");
-        SlackClient.sendMessageToUser(userId, ClockOutMessage);
+        SlackClient.sendMessageToUser(userId, CLOCK_OUT_MESSAGE);
       }
       timeEntryAsJson.end_date = timeEntry.getTimeToClockOut()
       await container.item(timeEntryAsJson.id, timeEntryAsJson.tenant_id).replace(timeEntryAsJson)
       totalClockOutsExecuted++
     }
   }));
   if (usersWithClockOut.length) {
-    const ClockOutMessageChannel=`${ClockOutMessage} \n- ${usersWithClockOut.join('\n- ')}`;
+    const ClockOutMessageChannel=`${CLOCK_OUT_MESSAGE} \n- ${usersWithClockOut.join('\n- ')}`;
     SlackClient.sendMessageToChannel(ClockOutMessageChannel);
   }
   context.log(`I just clocked out ${totalClockOutsExecuted} entries, thanks are not needed...`);
@@ -52,9 +52,9 @@ const findUserEmail = (users, id) => {
   return _.first(user.otherMails)
 }
 
-const findSlackUserId = (users,email)=>{
+const findSlackUserId = (users, email) => {
   const user = users.find(user => user.email === email);
-  return user? user.id:null
+  return user ? user.id : null
 }
 
-module.exports = {doClockOut};
+module.exports = { doClockOut };

AutomaticClockOuts/config.js

@@ -7,6 +7,7 @@ const config = {
     authority: process.env["AUTHORITY"],
     clientSecret: process.env["CLIENT_SECRET"],
     slackApiToken: process.env["SLACK_TOKEN_NOTIFY"],
+    channelId: process.env["ID_CHANNEL_NOTIFY"]
 };
 
 module.exports = config;

AutomaticClockOuts/constants.js

@@ -1,6 +1,5 @@
 const constants = {
-  ClockOutMessage : 'OMG, you have been working more than 12 hours in a row. \nPlease take a break and visit https://timetracker.ioet.com/ to set the right end time for your entries, we just did a clock out for you :wink:',
-  time_tracker_channel: 'C01694949JR'
+  CLOCK_OUT_MESSAGE : 'OMG, you have been working more than 12 hours in a row. \nPlease take a break and visit https://timetracker.ioet.com/ to set the right end time for your entries, we just did a clock out for you :wink:'
 };
 
 module.exports = constants;

AutomaticClockOuts/slack_client.js

@@ -1,6 +1,5 @@
 const { WebClient, LogLevel } = require("@slack/web-api");
-const { slackApiToken } = require("./config");
-const { time_tracker_channel } = require("./constants");
+const { slackApiToken, channelId } = require("./config");
 const client = new WebClient(slackApiToken, { logLevel: LogLevel.DEBUG });
 
 const findUsersInSlack = async () => {
@@ -26,7 +25,7 @@ const sendMessageToUser = (userId, message) => {
 
 // message to public channel
 const sendMessageToChannel = (message) => {
-  sendMessage(time_tracker_channel, message);
+  sendMessage(channelId, message);
 };
 
 module.exports = { findUsersInSlack, sendMessageToUser, sendMessageToChannel };

nodejs-functions/src/handlers/automatic-clock-outs/clock_out.js

@@ -5,13 +5,13 @@ const TimeEntry = require('./time_entry');
 const MsalClient = require('./msal_client');
 const TimeEntryDao = require('./time_entry_dao');
 const SlackClient = require('./slack_client');
-const { ClockOutMessage } = require('./constants');
+const { CLOCK_OUT_MESSAGE } = require('./constants');
 
 const doClockOut = async (context) => {
   context.log(`I am going to check how many entries were not clocked out ${new Date()}`);
 
   const { endpoint, key, databaseId } = config;
-  const client = new CosmosClient({endpoint, key});
+  const client = new CosmosClient({ endpoint, key});
   const database = client.database(databaseId);
   const container = database.container('time_entry');
   const timeEntryDao = new TimeEntryDao(database);
@@ -33,15 +33,15 @@ const doClockOut = async (context) => {
       const userId = findSlackUserId(slackUsers, user_email);
       if(userId){
         usersWithClockOut.push("<@"+userId+">");
-        SlackClient.sendMessageToUser(userId, ClockOutMessage);
+        SlackClient.sendMessageToUser(userId, CLOCK_OUT_MESSAGE);
       }
       timeEntryAsJson.end_date = timeEntry.getTimeToClockOut()
       await container.item(timeEntryAsJson.id, timeEntryAsJson.tenant_id).replace(timeEntryAsJson)
       totalClockOutsExecuted++
     }
   }));
   if (usersWithClockOut.length) {
-    const ClockOutMessageChannel=`${ClockOutMessage} \n- ${usersWithClockOut.join('\n- ')}`;
+    const ClockOutMessageChannel=`${CLOCK_OUT_MESSAGE} \n- ${usersWithClockOut.join('\n- ')}`;
     SlackClient.sendMessageToChannel(ClockOutMessageChannel);
   }
   context.log(`I just clocked out ${totalClockOutsExecuted} entries, thanks are not needed...`);
@@ -52,9 +52,9 @@ const findUserEmail = (users, id) => {
   return _.first(user.otherMails)
 }
 
-const findSlackUserId = (users,email)=>{
+const findSlackUserId = (users, email) => {
   const user = users.find(user => user.email === email);
-  return user? user.id:null
+  return user ? user.id : null
 }
 
-module.exports = {doClockOut};
+module.exports = { doClockOut };

nodejs-functions/src/handlers/automatic-clock-outs/config.js

@@ -7,6 +7,7 @@ const config = {
     authority: process.env["AUTHORITY"],
     clientSecret: process.env["CLIENT_SECRET"],
     slackApiToken: process.env["SLACK_TOKEN_NOTIFY"],
+    channelId: process.env["ID_CHANNEL_NOTIFY"]
 };
 
 module.exports = config;

nodejs-functions/src/handlers/automatic-clock-outs/constants.js

@@ -1,6 +1,5 @@
 const constants = {
-  ClockOutMessage : 'OMG, you have been working more than 12 hours in a row. \nPlease take a break and visit https://timetracker.ioet.com/ to set the right end time for your entries, we just did a clock out for you :wink:',
-  time_tracker_channel: 'C01694949JR'
+  CLOCK_OUT_MESSAGE : 'OMG, you have been working more than 12 hours in a row. \nPlease take a break and visit https://timetracker.ioet.com/ to set the right end time for your entries, we just did a clock out for you :wink:'
 };
 
 module.exports = constants;

nodejs-functions/src/handlers/automatic-clock-outs/slack_client.js

@@ -1,6 +1,5 @@
 const { WebClient, LogLevel } = require("@slack/web-api");
-const { slackApiToken } = require("./config");
-const { time_tracker_channel } = require("./constants");
+const { slackApiToken, channelId } = require("./config");
 const client = new WebClient(slackApiToken, { logLevel: LogLevel.DEBUG });
 
 const findUsersInSlack = async () => {
@@ -26,7 +25,7 @@ const sendMessageToUser = (userId, message) => {
 
 // message to public channel
 const sendMessageToChannel = (message) => {
-  sendMessage(time_tracker_channel, message);
+  sendMessage(channelId, message);
 };
 
 module.exports = { findUsersInSlack, sendMessageToUser, sendMessageToChannel };