fix: AD order in IESG ballots (and other places) does not handle UTF-8 collation#9836
fix: AD order in IESG ballots (and other places) does not handle UTF-8 collation#9836rjsparks merged 6 commits intoietf-tools:mainfrom
Conversation
|
Working on fixing ietf.iesg.tests.IESGTests.test_working_groups as the test was not expecting a sorted table ;-) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9836 +/- ##
==========================================
- Coverage 88.54% 88.54% -0.01%
==========================================
Files 316 317 +1
Lines 42265 42273 +8
==========================================
+ Hits 37423 37430 +7
- Misses 4842 4843 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This has the same issue interacting with tablesorter - clicking on the tables won't get the same sort result as this PR passes in now. |
AFAIK, this was taken into consideration and tested with the current IESG for "..., Éric, Erik, ..." whose order is unchanged between Python generated first list and then after applying JS lists.js sorting. |
Fix #9483
Using a new ietf/utils/unicodenormalize.py to basically transform "Éric" into "Eric" and using this ancillary function for ballots, WG AD dashboard, and milestones under review.