Skip to content

fix: improve pw validation without js#9113

Merged
rjsparks merged 9 commits intoietf-tools:mainfrom
jennifer-richards:pw-reset-nojs
Jul 10, 2025
Merged

fix: improve pw validation without js#9113
rjsparks merged 9 commits intoietf-tools:mainfrom
jennifer-richards:pw-reset-nojs

Conversation

@jennifer-richards
Copy link
Copy Markdown
Member

Fixes issues with poor / absent feedback about rejected passwords when passwords are reset, changed, or initially created in a browser with javascript disabled.

It's tempting to go on a deeper dive refactoring the password forms, but I think this is a sensible stopping point. This will need more serious work when we move to an external auth system and/or migrate to Django 5.

Comment thread ietf/ietfauth/forms.py
Comment thread ietf/ietfauth/forms.py
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (0197e44) to head (7326422).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9113      +/-   ##
==========================================
- Coverage   88.75%   88.73%   -0.02%     
==========================================
  Files         321      321              
  Lines       41851    41853       +2     
==========================================
- Hits        37143    37140       -3     
- Misses       4708     4713       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rjsparks rjsparks merged commit 58bc7c9 into ietf-tools:main Jul 10, 2025
10 checks passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants