refactor: reimplement purple API in django-rest-framework#9097
Merged
jennifer-richards merged 28 commits intofeat/rpc-apifrom Jul 8, 2025
Merged
refactor: reimplement purple API in django-rest-framework#9097jennifer-richards merged 28 commits intofeat/rpc-apifrom
jennifer-richards merged 28 commits intofeat/rpc-apifrom
Conversation
Changes the interface to return a list of Persons instead of a map from ID to name.
Gets turned into a literal nul somewhere in the process of generating a schema and building a Python client for purple. This has the same effect but avoids the nul.
Side effect is that the purple API client is named PurpleApi instead of RpcApi.
refactor: reimplement rpcapi in DRF
This prevents at least one existing draft from being looked up.
This reverts commit 63f40cf
fix: debug drf rpcapi
chore: merge feat/rpc-api into feat/rpc-api-drf
This reverts commit d8656f4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft until we verify that the rfced-xfer process is giving us the same results as the original.