fix: debug drf rpcapi#9096
Merged
jennifer-richards merged 5 commits intoietf-tools:feat/rpc-api-drffrom Jul 5, 2025
Merged
Conversation
This prevents at least one existing draft from being looked up.
This reverts commit 63f40cf
rudimatz
reviewed
Jul 4, 2025
| regex="^[^\x01-\x1f]*$", | ||
| message="Please enter a string without control characters.", | ||
| ) | ||
| regex="^[^\x00-\x1f]*$", |
Member
Author
There was a problem hiding this comment.
Yes indeed, good catch. However, I'm inclined to leave it because this is reverting back to the strangely indented original on the main branch. When we squash-merge the feat/rpc-api-drf branch back to main, the net result will leave the lines alone so I think it's better not to link it to this PR in the history.
rudimatz
approved these changes
Jul 4, 2025
jennifer-richards
merged commit e6f76a4
into
ietf-tools:feat/rpc-api-drf
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few bugs that were discovered while reconciling the code with the rfced-xfer project.
The refactor in cd01a16 renders unnecessary the earlier change to the
DocumentInfo.titlevalidation, so this PR reverts that change. The code on this branch has not been deployed anywhere, so we can just remove the migration rather than reversing it in a new one.