Skip to content

fix: approve slides link for all pending submissions#8692

Merged
rjsparks merged 8 commits intoietf-tools:mainfrom
jennifer-richards:pending-slides-for-all-sessions
Mar 18, 2025
Merged

fix: approve slides link for all pending submissions#8692
rjsparks merged 8 commits intoietf-tools:mainfrom
jennifer-richards:pending-slides-for-all-sessions

Conversation

@jennifer-richards
Copy link
Copy Markdown
Member

Fixes issue where only slides attached to the first session at a meeting were shown for chair approval. Refactors the view a bit to flatten some redundant authentication checks and simplify typing.

Fixes #6045

rjsparks
rjsparks previously approved these changes Mar 18, 2025
rjsparks
rjsparks previously approved these changes Mar 18, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (70bf2ae) to head (03dcaf7).
Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8692      +/-   ##
==========================================
- Coverage   88.88%   88.81%   -0.08%     
==========================================
  Files         312      314       +2     
  Lines       40891    41244     +353     
==========================================
+ Hits        36345    36629     +284     
- Misses       4546     4615      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rjsparks rjsparks merged commit 563fcee into ietf-tools:main Mar 18, 2025
10 checks passed
@jennifer-richards jennifer-richards deleted the pending-slides-for-all-sessions branch March 18, 2025 11:00
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

no notification about proposed slides for IABopen

2 participants