refactor: Remove decorator dependency from debug.py#7219
Merged
rjsparks merged 1 commit intoietf-tools:mainfrom Mar 18, 2024
microamp:refactor/decorator-debug-py
Merged
refactor: Remove decorator dependency from debug.py#7219rjsparks merged 1 commit intoietf-tools:mainfrom microamp:refactor/decorator-debug-py
rjsparks merged 1 commit intoietf-tools:mainfrom
microamp:refactor/decorator-debug-py
Conversation
microamp
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7219 +/- ##
==========================================
- Coverage 88.98% 88.94% -0.05%
==========================================
Files 291 291
Lines 40717 41067 +350
==========================================
+ Hits 36233 36527 +294
- Misses 4484 4540 +56 ☔ View full report in Codecov by Sentry. |
rjsparks
reviewed
Mar 18, 2024
| types-python-dateutil>=2.8.2 | ||
| python-magic==0.4.18 # Versions beyond the yanked .19 and .20 introduce form failures | ||
| pymemcache>=4.0.0 # for django.core.cache.backends.memcached.PyMemcacheCache | ||
| pymemcache>=4.0.0 # for django.core.cache.backends.memcached.PyMemcacheCache |
Member
There was a problem hiding this comment.
nit - try not to bring in unrelated whitespace changes - put those in their own PR. (Otherwise time gets wasted later chasing back through revisions to find why the lines really changed.)
rjsparks
approved these changes
Mar 18, 2024
jennifer-richards
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR removes the
decoratordependency fromdebug.py. This should complete #5654.See also: #7199