Skip to content

refactor: Remove decorator dependency from utils#7199

Merged
rjsparks merged 1 commit into
ietf-tools:mainfrom
microamp:refactor/decorator
Mar 16, 2024
Merged

refactor: Remove decorator dependency from utils#7199
rjsparks merged 1 commit into
ietf-tools:mainfrom
microamp:refactor/decorator

Conversation

@microamp

Copy link
Copy Markdown
Contributor

Fixes #5654

I have noticed that decorator is also being used in debug.py, so it will remain in requirements.txt for now.

@codecov

codecov Bot commented Mar 16, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 80.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 88.94%. Comparing base (187c2c5) to head (0f76a19).
Report is 62 commits behind head on main.

Files Patch % Lines
ietf/utils/decorators.py 80.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7199      +/-   ##
==========================================
- Coverage   88.98%   88.94%   -0.05%     
==========================================
  Files         291      291              
  Lines       40717    41067     +350     
==========================================
+ Hits        36233    36527     +294     
- Misses       4484     4540      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jennifer-richards jennifer-richards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok - would be good to give the same treatment to debug.py, but that could go into a separate PR.

@rjsparks
rjsparks merged commit 1a9a111 into ietf-tools:main Mar 16, 2024
@microamp
microamp deleted the refactor/decorator branch March 17, 2024 13:39
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor to drop dependency on decorator package

3 participants