fix: Only insert <wbr> when there isn't a space before or after#6821
Merged
rjsparks merged 2 commits intoietf-tools:feat/clarityfrom Dec 20, 2023
Merged
fix: Only insert <wbr> when there isn't a space before or after#6821rjsparks merged 2 commits intoietf-tools:feat/clarityfrom
rjsparks merged 2 commits intoietf-tools:feat/clarityfrom
Conversation
cabo
reviewed
Dec 20, 2023
| .text(); | ||
| // insert some <wbr> at strategic places | ||
| var newtext = text.replace(/([@._+])/g, "$1<wbr>"); | ||
| var newtext = text.replace(/\S([@._+])\S/g, "$1<wbr>"); |
Collaborator
There was a problem hiding this comment.
"123.456".replace(/([@._+])/g, "$1<wbr>");
'123.<wbr>456'
"123.456".replace(/\S([@._+])\S/g, "$1<wbr>");
'12.<wbr>56'
Contributor
|
Oh, ta! |
rjsparks
approved these changes
Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue @wkumari raised in email.