fix: Use String.prototype.localeCompare() when sorting table rows#6441
Merged
rjsparks merged 1 commit intoietf-tools:mainfrom Oct 10, 2023
Merged
fix: Use String.prototype.localeCompare() when sorting table rows#6441rjsparks merged 1 commit intoietf-tools:mainfrom
rjsparks merged 1 commit intoietf-tools:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6441 +/- ##
==========================================
- Coverage 88.81% 88.69% -0.12%
==========================================
Files 290 290
Lines 40879 40431 -448
==========================================
- Hits 36305 35859 -446
+ Misses 4574 4572 -2
|
jennifer-richards
approved these changes
Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix some js warnings and indentation nits while I'm here.
Fixes #6437