Skip to content

refactor: Allow existing Person in create_demo_person #6398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jennifer-richards merged 2 commits into from
Sep 28, 2023
Merged

refactor: Allow existing Person in create_demo_person #6398

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55651ee
refactor: Allow existing Person in create_demo_person
jennifer-richards Sep 28, 2023
1d1dd33
Merge branch 'feat/rpc-api' into allow-existing-demopeople
jennifer-richards Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions ietf/api/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,7 @@ def submitted_to_rpc(request):

return JsonResponse(response)


@csrf_exempt
def create_demo_person(request):
""" Helper for creating rpc demo objects - SHOULD NOT MAKE IT INTO PRODUCTION
Expand All @@ -501,12 +502,9 @@ def create_demo_person(request):

request_params = json.loads(request.body)
name = request_params["name"]
if Person.objects.filter(name=name).exists():
return HttpResponseForbidden()
person = PersonFactory(name=name)

person = Person.objects.filter(name=name).first() or PersonFactory(name=name)
return JsonResponse({"user_id":person.user.pk,"person_pk":person.pk}, status=201)

return JsonResponse({"user_id":person.user.pk,"person_pk":person.pk})

@csrf_exempt
def create_demo_draft(request):
Expand Down Expand Up @@ -535,5 +533,3 @@ def create_demo_draft(request):
kwargs["states"] = states
doc = WgDraftFactory(**kwargs)
return JsonResponse({ "doc_id":doc.pk, "name":doc.name })