refactor: Allow existing Person in create_demo_person#6398
Merged
jennifer-richards merged 2 commits intoietf-tools:feat/rpc-apifrom Sep 28, 2023
Merged
Conversation
rjsparks
approved these changes
Sep 28, 2023
Member
Author
|
Oops, thought I'd merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of returning a 403 Forbidden error, just return the existing
Personif acreate_demo_person()API call tries to create a person who already exists. This avoids having to clean out the datatracker DB when re-runningcreate_rpc_demoin the rpc tool.Could instead handle the 403 (or return a distinct indicator that the name is in use, perhaps a 409 Conflict) and deal with this on the API caller side, but this is the lower hanging fix