feat: replace references to User with references to Person

[rjsparks]

No description provided.

[codecov]

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (b38e8c3) 88.80% compared to head (bf6ae7d) 88.91%.
Report is 9 commits behind head on main.

Files	Patch %	Lines
ietf/community/views.py	80.00%	12 Missing ⚠️
ietf/doc/utils.py	88.88%	1 Missing ⚠️
ietf/nomcom/utils.py	90.90%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6024      +/-   ##
==========================================
+ Coverage   88.80%   88.91%   +0.11%     
==========================================
  Files         285      289       +4     
  Lines       40383    40454      +71     
==========================================
+ Hits        35862    35971     +109     
+ Misses       4521     4483      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rjsparks]

Leaving some notes here from a deep dive into the edge cases.

There are users without persons.

These migrations currently would lose some data about who (for a very poor value of who - all we would lose is a username since there's no person connected already) made nominations in very old nomcoms. That data is supposed to have been removed already anyhow, so I'm not particularly concerned about that.

There are communitylists attacted to users without persons. Unless these also have EmailSubscriptions, they don't do anything anyhow and deleting them is safe. There is only one that has an EmailSubscription attached at the moment. I'll appoach the owner and adjust that one away.

Then we should add explicitly removing the personless objects instead of migrating them to person=None - the migrations will need to be updated.

[jennifer-richards]

There are communitylists attacted to users without persons. Unless these also have EmailSubscriptions, they don't do anything anyhow and deleting them is safe. There is only one that has an EmailSubscription attached at the moment. I'll appoach the owner and adjust that one away.

This appears to have been done. On production:

>>> CommunityList.objects.filter(user__person__isnull=True).exclude(user__isnull=True).exclude(emailsubscription__isnull=True).count()
0

[jennifer-richards]

These migrations currently would lose some data about who (for a very poor value of who - all we would lose is a username since there's no person connected already) made nominations in very old nomcoms. That data is supposed to have been removed already anyhow, so I'm not particularly concerned about that.

Looks like there are only 5 nominations affected if I'm understanding this correctly. The most recent was in 2018.

datatracker=> SELECT COUNT(*)
datatracker-> FROM nomcom_nomination nom
datatracker->          LEFT OUTER JOIN person_person p USING (user_id)
datatracker-> WHERE nom.user_id IS NOT NULL
datatracker->   AND p.id IS NULL;
 count
-------
     5
(1 row)

There are also 51 nominations with no User at all, the latest in 2019.

[jennifer-richards]

Looks like there are also 199 Feedback instances tied to Personless users. I'm guessing these are in the same category as the Nomination instances - there's still a field indicating the author, there's just no link to a Person. The latest of these were in 2021.