fix: review refactoring issue#6018
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6018 +/- ##
==========================================
- Coverage 88.67% 88.64% -0.04%
==========================================
Files 288 288
Lines 40001 40000 -1
==========================================
- Hits 35471 35456 -15
- Misses 4530 4544 +14
|
rjsparks
changed the title
rjsparks
changed the title
rjsparks
approved these changes
Jul 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5447
As none of the policies really implement return to the top operation, I changed this to set_wants_to_be_next. When review is rejected it did not really change the wants_to_be_next at all, it kept it as it was before, so I removed call to that completely. It now calls this only when review is withdrawn, in which case it unconditionally sets the wants to be next flag for that person.