There are concepts coded into method names that don't reflect what the method really does. The one that caused me to enter this issue is return_reviewer_to_rotation_top, which implies it will change the queue itself. What it does, instead, is set a bit that tells the scheduling algorithm to ignore the queue and take this person as soon as possible. (Note that multiple reviewers might have set this bit).
The tests need to be adjusted to become better documentation of what the code is supposed to be doing.
There are concepts coded into method names that don't reflect what the method really does. The one that caused me to enter this issue is return_reviewer_to_rotation_top, which implies it will change the queue itself. What it does, instead, is set a bit that tells the scheduling algorithm to ignore the queue and take this person as soon as possible. (Note that multiple reviewers might have set this bit).
The tests need to be adjusted to become better documentation of what the code is supposed to be doing.