Skip to content

fix: More dark mode fixes #5852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 5 commits into from
Jun 21, 2023
Merged

fix: More dark mode fixes #5852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3973c3
fix: Correctly indicate "auto" theme is default
larseggert Jun 19, 2023
2ec5287
fix: .pnp.js changes were missing
larseggert Jun 19, 2023
956facb
fix: Use a "-subtle" background color for the menu bar
larseggert Jun 19, 2023
1328c76
fix: Try and recolor black colors in SVGs for dark mode
larseggert Jun 20, 2023
506c6f3
Apply suggestions from @martinthomson
larseggert Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pnp.cjs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions ietf/static/css/document_html_txt.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,4 +450,19 @@ section > p, section > dl.references > dd {
* doesn't break words at '/' like other browsers. */
overflow-wrap: break-word;
}

/* From https://github.com/martinthomson/rfc-css/blob/main/rfc.css */
/* SVG Trick: a prefix match works because only black and white are allowed */
svg :is([stroke="black"], [stroke^="#000"]) {
stroke: var(--bs-body-color);
}
svg :is([stroke="white"], [stroke^="#fff"]) {
stroke: var(--bs-body-bg);
}
svg :is([fill="black"], [fill^="#000"], :not([fill])) {
fill: var(--bs-body-color);
}
svg :is([fill="white"], [fill^="#fff"]) {
fill: var(--bs-body-bg);
}
}
2 changes: 1 addition & 1 deletion ietf/static/js/theme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
(() => {
"use strict";

const storedTheme = localStorage.getItem("theme");
const storedTheme = localStorage.getItem("theme") || "auto";

const getPreferredTheme = () => {
if (storedTheme) {
Expand Down
2 changes: 1 addition & 1 deletion ietf/templates/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
data-group-menu-data-url="{% url 'ietf.group.views.group_menu_data' %}">
{% analytical_body_top %}
<a class="visually-hidden visually-hidden-focusable" href="#content">Skip to main content</a>
<nav class="navbar navbar-expand-lg fixed-top {% if server_mode and server_mode != "production" %}bg-warning navbar-light{% else %}navbar-dark bg-secondary{% endif %}">
<nav class="navbar navbar-expand-lg fixed-top {% if server_mode and server_mode != "production" %}bg-danger-subtle navbar-light{% else %}navbar-dark bg-secondary{% endif %}">
<div class="container-fluid">
<a class="navbar-brand" href="/">
<img alt="IETF Logo" class="me-2"
Expand Down