fix: More dark mode fixes - #5852
Merged
Merged
Conversation
Because those change correctly with theme changes. That the non-"-subtle" ones may be a bs5 bug, but enough people complained about the yellow background in dev mode in dark mode that this change may be worth it.
martinthomson
left a comment
martinthomson
left a comment
Contributor
There was a problem hiding this comment.
https://dt-dark-mode.dev.ietf.org/static/ietf/images/ietf-logo.svg probably needs tweaking also. See the home page.
Collaborator
Author
|
@martinthomson there is https://github.com/ietf-tools/datatracker/blob/feat/dark-mode/ietf/static/images/ietf-logo-white.svg already on that feature branch. (And others.) |
Member
|
Not a dark mode thing per say, but Bootstrap 5.3 deprecates the |
Collaborator
Author
|
@NGPixel we should probably do another PR that replaces deprecated things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.