Skip to content

fix: be more sure to create interim's timeslot / update duration #4846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 1 commit into from
Dec 7, 2022
Merged

fix: be more sure to create interim's timeslot / update duration #4846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions ietf/meeting/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1060,8 +1060,7 @@ def sessions_post_save(request, forms):
by=request.user.person,
)

if ('date' in form.changed_data) or ('time' in form.changed_data):
update_interim_session_assignment(form)
update_interim_session_assignment(form)
if 'agenda' in form.changed_data:
form.save_agenda()

Expand Down Expand Up @@ -1140,6 +1139,8 @@ def update_interim_session_assignment(form):
"""Helper function to create / update timeslot assigned to interim session

form is an InterimSessionModelForm

Only updates timeslot time (a datetime) and duration
"""
session = form.instance
meeting = session.meeting
Expand All @@ -1148,9 +1149,10 @@ def update_interim_session_assignment(form):
)
if session.official_timeslotassignment():
slot = session.official_timeslotassignment().timeslot
slot.time = time
slot.duration = session.requested_duration
slot.save()
if slot.time != time or slot.duration != session.requested_duration:
slot.time = time
slot.duration = session.requested_duration
slot.save()
else:
slot = TimeSlot.objects.create(
meeting=meeting,
Expand Down