fix: be more sure to create interim's timeslot / update duration#4846
Merged
rjsparks merged 1 commit intoDec 7, 2022
Merged
Conversation
rjsparks
approved these changes
Dec 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to prevent the error in #4833 from recurring. I have not been able to reproduce the reported failure, though. Somehow the attempt to edit the interim resulted in sessions being created without the necessary timeslots.
The change here ensures that, whether or not the form thinks the date/time have changed, it will create a timeslot for a session if one is needed. Even if this is not causing #4833, I think this is a more robust strategy.
This also updates the timeslot duration when the session's requested_duration changes. Previously this was done only if the time or date changed.