Skip to content

chore: Update deps#4162

Merged
rjsparks merged 2 commits intoietf-tools:mainfrom
larseggert:update-deps
Jul 7, 2022
Merged

chore: Update deps#4162
rjsparks merged 2 commits intoietf-tools:mainfrom
larseggert:update-deps

Conversation

@larseggert
Copy link
Copy Markdown
Collaborator

There are these yarn messages, which I don't understand, but @NGPixel may.

➤ YN0000: ┌ Resolution step
➤ YN0060: │ @parcel/optimizer-image@npm:2.6.2 provides @parcel/core (pec760) with version 2.5.0, which doesn't satisfy what @parcel/workers requests
➤ YN0060: │ @parcel/types@npm:2.6.2 provides @parcel/core (p1835f) with version 2.5.0, which doesn't satisfy what @parcel/fs requests
➤ YN0060: │ @parcel/types@npm:2.6.2 provides @parcel/core (p40766) with version 2.5.0, which doesn't satisfy what @parcel/workers requests
➤ YN0060: │ @parcel/types@npm:2.6.2 provides @parcel/core (p60182) with version 2.5.0, which doesn't satisfy what @parcel/cache requests
➤ YN0060: │ @parcel/types@npm:2.6.2 provides @parcel/core (pe24cb) with version 2.5.0, which doesn't satisfy what @parcel/package-manager requests
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed

There are these yarn messages, which I don't understand, but @NGPixel may.

```
➤ YN0000: ┌ Resolution step
➤ YN0060: │ @parcel/optimizer-image@npm:2.6.2 provides @parcel/core (pec760) with version 2.5.0, which doesn't satisfy what @parcel/workers requests
➤ YN0060: │ @parcel/types@npm:2.6.2 provides @parcel/core (p1835f) with version 2.5.0, which doesn't satisfy what @parcel/fs requests
➤ YN0060: │ @parcel/types@npm:2.6.2 provides @parcel/core (p40766) with version 2.5.0, which doesn't satisfy what @parcel/workers requests
➤ YN0060: │ @parcel/types@npm:2.6.2 provides @parcel/core (p60182) with version 2.5.0, which doesn't satisfy what @parcel/cache requests
➤ YN0060: │ @parcel/types@npm:2.6.2 provides @parcel/core (pe24cb) with version 2.5.0, which doesn't satisfy what @parcel/package-manager requests
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed
```
@larseggert larseggert requested a review from NGPixel July 5, 2022 13:45
@NGPixel
Copy link
Copy Markdown
Member

NGPixel commented Jul 5, 2022

These warnings are because these parcel packages don't properly specify their dependencies and rely on some other package including them (which is bad practice, see this blog post).

The solution is to specify them in .yarnrc.yml (see https://github.com/ietf-tools/datatracker/blob/main/.yarnrc.yml#L7-L22)

So for example, in your warnings, the first one being "@parcel/workers" missing dependency "@parcel/core", you would add to .yarnrc.yml:

"@parcel/workers@*":
  dependencies:
    "@parcel/core": "*"

These warnings should then disappear the next time you run yarn.

@larseggert
Copy link
Copy Markdown
Collaborator Author

I added that to .yarnrc.yml, but the warning still shows when I do yarn rebuild.

I also noticed there are already similar blocks for @parcel/optimizer-image and @parcel/types, but they don't suppress the warnings either?

@NGPixel
Copy link
Copy Markdown
Member

NGPixel commented Jul 6, 2022

It works using this .yarnrc.yml:

defaultSemverRangePrefix: ""

enableTelemetry: false

nodeLinker: pnp

packageExtensions:
  "@parcel/optimizer-image@*":
    dependencies:
      "@parcel/core": "2.6.2"
  "@parcel/fs@*":
    dependencies:
      "@parcel/core": "2.6.2"
  "@parcel/workers@*":
    dependencies:
      "@parcel/core": "2.6.2"
  "@parcel/cache@*":
    dependencies:
      "@parcel/core": "2.6.2"
  "@parcel/package-manager@*":
    dependencies:
      "@parcel/core": "2.6.2"
  "select2-bootstrap-5-theme@*":
    dependencies:
      "@popperjs/core": "*"

plugins:
  - path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs
    spec: "@yarnpkg/plugin-interactive-tools"

supportedArchitectures:
  cpu:
    - "x64"
    - "arm64"
  os:
    - "darwin"
    - "linux"
    - "win32"

yarnPath: .yarn/releases/yarn-3.2.0.cjs

@rjsparks rjsparks merged commit dfc0ebc into ietf-tools:main Jul 7, 2022
@larseggert larseggert deleted the update-deps branch July 7, 2022 17:43
@rjsparks
Copy link
Copy Markdown
Member

rjsparks commented Jul 7, 2022

I made a mistake merging this - too trained to ignore the test runs. I'm going to revert it. Please bring in a new PR where the Agenda_js tests don't fail

rjsparks added a commit that referenced this pull request Jul 7, 2022
rjsparks added a commit that referenced this pull request Jul 7, 2022
@larseggert
Copy link
Copy Markdown
Collaborator Author

@rjsparks see #4203

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants