Skip to content

fix: Add popup to explain colors for liaisons needing action. Rework how aria-label is supplied for several input fields. Update vnu.jar. Adjust some field styling. - #4115

Merged
rjsparks merged 2 commits into
ietf-tools:mainfrom
larseggert:fix-4078
Jul 7, 2022

Conversation

@larseggert

Copy link
Copy Markdown
Collaborator

Also fix the search field styling while I'm here.

Fixes #4078.

@larseggert
larseggert marked this pull request as draft June 22, 2022 14:40
@larseggert

Copy link
Copy Markdown
Collaborator Author

Converting to draft; need to check if this validates

@larseggert
larseggert marked this pull request as ready for review July 4, 2022 15:32
@rjsparks

rjsparks commented Jul 7, 2022

Copy link
Copy Markdown
Member

I can't quickly find what this PR claims it is doing - where is the popup?
There's so much else here - why isn't it in another PR?

Comment on lines +24 to +25
<span title="{{ liaison.is_outgoing|yesno:'Outgoing,Incoming' }} liaison"
class="badge rounded-pill

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjsparks popup is here

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - I was skimming for more than a tooltip - thanks.
I still think the PR submarines a bunch of unrelated changes in, but I think I can address that by changing the PR title (which is what will end up in the release notes).

One last question: did you consider adding the aria information to the Form class instead of decorating that information in using the templates?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh - fighting the attributes through the widgets isn't likely to be worth the effort.
I see though that vnu.jar also changed - is this a version update or something?

Really - please functionally separate these kinds of changes going forward.

@rjsparks rjsparks changed the title fix: Add popup to explain colors for liaisons needing action fix: Add popup to explain colors for liaisons needing action. Rework how aria-label is supplied for several input fields. Adjust some field styling. Jul 7, 2022
@rjsparks rjsparks changed the title fix: Add popup to explain colors for liaisons needing action. Rework how aria-label is supplied for several input fields. Adjust some field styling. fix: Add popup to explain colors for liaisons needing action. Rework how aria-label is supplied for several input fields. Update vnu.jar. Adjust some field styling. Jul 7, 2022
@rjsparks
rjsparks merged commit 01abc93 into ietf-tools:main Jul 7, 2022
@larseggert
larseggert deleted the fix-4078 branch July 8, 2022 06:19
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Action Needed" liaison color is not labelled or explained

2 participants