fix: restore time zone widget to agenda RH nav panel#3792
Conversation
Adds a horizontal line in the "info" theme color above the agenda row for the next session. Rows are already marked as ongoing by changing their backgrounds, but this allows the current time to be indicated when there are no sessions ongoing (e.g., overnight between meeting days).
* Use boostrap "card" class to format righthand panel * Tweak container styles to better handle multiple elements * Remove fixed height on righthand-nav item
# Conflicts: # ietf/static/js/agenda_timezone.js
* add "minimal" option to render tz select buttons only * move tz-display "onchange" events into timezone.js * update timezone.js to handle radio inputs in addition to select * render second timezone select widget on the agenda's floating RH panel
Previously, kept the magic word "local" to guess the local timezone, but this complicates keeping multiple sets of radios in sync. Instead, replace "local" with guessed timezone name at init time.
It will show until the end of the day, styled to indicate that it is not functional.
Codecov Report
@@ Coverage Diff @@
## feat/bs5 #3792 +/- ##
=========================================
Coverage 87.97% 87.97%
=========================================
Files 296 297 +1
Lines 38795 38804 +9
=========================================
+ Hits 34130 34139 +9
Misses 4665 4665
Continue to review full report at Codecov.
|
…z-widget # Conflicts: # ietf/static/js/agenda_timezone.js # ietf/templates/meeting/agenda.html # ietf/templates/meeting/tz-display.html
|
Why is the righthand-nav a card now? That makes no sense structurally and also introduces styling oddities. (Of which there are other ones, e.g., the nav content is now vertically centered?) Also, the timezone picker needs to be layed out vertically or at least wrap correctly |
|
What is the structural problem with a card? As far as I can tell, it's a utility component that makes content-in-a-box. What's there is (loosely) modeled on the kitchen sink example. The vertical alignment is because of a flexbox in need of an align-items-start. There's some styling strangeness tied to the timezone picker being too wide. What other oddities are you referring to? I'm not thrilled at the prospect of making the timezone picker vertical because it will be less distinct from the nav links above it. It does need to behave better. It could also revert to being text links like it was before. That's not as snazzy, but the display immediately above it already indicates the timezone so the fancy highlighting is not essential. |
|
Also see #3798. Regarding card, I was under the impression that is mostly for displaying series of identical/similar things, with some convenient formatting that applies across the series. The added border and whitespace (to me) clash with the leftmenu, which doesn't have those. Regarding oddities, yes, that the content no longer wraps. I agree it doesn't look great when the timezone picker does, but at least it would remain usable that way. |
3 participants
This restores the functionality of the agenda time zone selection widget, extends it to support a compact mode, and adds that compact display to the RH nav panel. This restores a feature that was dropped in the initial bs5 facelift.
Creating as a draft because this builds on #3790. Once that is approved/merged, I'll straighten this out.
Fixes #3700, #3737, and #3757.