Skip to content

chore: improve dev docker for offline + other fixes#3652

Merged
rjsparks merged 1 commit into
ietf-tools:mainfrom
NGPixel:docker-improve
Mar 16, 2022
Merged

chore: improve dev docker for offline + other fixes#3652
rjsparks merged 1 commit into
ietf-tools:mainfrom
NGPixel:docker-improve

Conversation

@NGPixel

@NGPixel NGPixel commented Mar 16, 2022

Copy link
Copy Markdown
Member

Docker Changes

  • change docker-compose end behavior from down to stop
  • set workspace directory to /workspace instead of /root/src to address issues mentioned by @jennifer-richards

NPM Changes

  • pre-install npm modules during image build
  • add --prefer-offline flag to npm install during container start
  • disable the npm funding and auditing messages during init install

VS Code Changes

  • make the wait-for script available offline instead of fetching it during vscode container start
  • add gitlens, indent-rainbow and volar extensions to the default vscode config

@NGPixel NGPixel requested a review from rjsparks March 16, 2022 00:09
@rjsparks rjsparks merged commit 868afd2 into ietf-tools:main Mar 16, 2022
@NGPixel NGPixel deleted the docker-improve branch March 16, 2022 16:02
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants