Skip to content

test: prevent periodic failure of test_send_reminder_all_open_reviews() #3584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 1 commit into from
Mar 7, 2022
Merged

test: prevent periodic failure of test_send_reminder_all_open_reviews() #3584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ietf/review/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
from .utils import (email_secretary_reminder, review_assignments_needing_secretary_reminder,
email_reviewer_reminder, review_assignments_needing_reviewer_reminder,
send_reminder_unconfirmed_assignments, send_review_reminder_overdue_assignment,
send_reminder_all_open_reviews, send_unavailability_period_ending_reminder)
send_reminder_all_open_reviews, send_unavailability_period_ending_reminder,
ORIGIN_DATE_PERIODIC_REMINDERS)

class HashTest(TestCase):

Expand All @@ -28,7 +29,7 @@ def test_hash_list_message_id(self):
(b'xml2rfc', b'3A0F4CD6-451F-44E2-9DA4-28235C638588@rfc-editor.org','g6DN4SxJGDrlSuKsubwb6rRSePU'),
):
self.assertEqual(hash, hash_list_message_id(list, msgid))


class ReviewAssignmentTest(TestCase):
def do_test_update_review_req_status(self, assignment_state, expected_state):
Expand Down Expand Up @@ -468,6 +469,7 @@ def test_send_review_reminder_overdue_assignment(self):
self.assertIn('1 overdue review', log[0])

def test_send_reminder_all_open_reviews(self):
today = datetime.date.today()
self.make_secretary(username='reviewsecretary')
ReviewerSettingsFactory(team=self.team, person=self.reviewer, remind_days_open_reviews=1)

Expand All @@ -483,10 +485,14 @@ def test_send_reminder_all_open_reviews(self):
assigned_on=second_req.time,
reviewer=self.reviewer.email(),
)
ReviewerSettingsFactory(team=second_team, person=self.reviewer, remind_days_open_reviews=13)
ReviewerSettingsFactory(
team=second_team,
person=self.reviewer,
# set the reminder never to be due to be sent today for this team
remind_days_open_reviews=(today - ORIGIN_DATE_PERIODIC_REMINDERS).days + 1,
)

empty_outbox()
today = datetime.date.today()
log = send_reminder_all_open_reviews(today)

self.assertEqual(len(outbox), 1)
Expand Down