test: prevent periodic failure of test_send_reminder_all_open_reviews()#3584
Merged
Merged
Conversation
rjsparks
approved these changes
Mar 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ietf.review.tests.ReviewAssignmentTest.test_send_reminder_all_open_reviewstest verifies that reminders are sent with the periodicity configured for each review team. It sets up two review teams, intending that only one will be sent a notification. The team not to receive a notification was set to receive one every 13 days, however, which leads to the test failing every 13 days.To fix, this patch determines how many days have elapsed since the
ORIGIN_DATE_PERIODIC_REMINDERSand configures the no-notification review team to receive notifications less often than this.